[Firebase AI] Add includeSafetyAttributes for Imagen requests
#15191
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the includeSafetyAttributes parameter for Imagen requests, hardcoding it to true to enable safety attribute scoring for monitoring purposes. The changes are well-implemented across the model and parameter definitions. The new property is correctly added to ImageGenerationParameters and its encoding logic. The accompanying test updates are comprehensive, covering the new parameter in various scenarios, including its presence in request encoding and its absence when nil. The implementation is clean, correct, and aligns with the stated objectives.
Added an
includeSafetyAttributestoImageGenerationParameters. This is hardcoded totrueso that safety attribute scores are included in responses. These are not surfaced in the SDK itself but will be visible in Firebase AI Monitoring.#no-changelog